Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icu4c source dists not including an actual LICENSE file #2804

Closed
wants to merge 1 commit into from
Closed

Fix icu4c source dists not including an actual LICENSE file #2804

wants to merge 1 commit into from

Conversation

Phenix66
Copy link

This fixes an issue introduced by https://unicode-org.atlassian.net/browse/ICU-21964

When attempting to build the library from the icu4c-74_2-src.tgz release artifact, I received an error from make install about a nonexistent file ../LICENSE. This was because the symlink was included in the dist that then references a file outside of the dist. Simple fix, just make the actual file is included when building the dist in the pipeline.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-_____
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

@markusicu
Copy link
Member

@mihnita @srl295 this seems to say that ICU-22601 PR #2749 was not sufficient?

@srl295
Copy link
Member

srl295 commented Jan 25, 2024

@mihnita @srl295 this seems to say that ICU-22601 PR #2749 was not sufficient?

https://github.com/unicode-org/icu/releases/tag/release-74-2 It doesn't look like anyone ever copied the FIXED .tgz over, regenerated the checksums, and moved the 74.2 out of pre-release?

@srl295
Copy link
Member

srl295 commented Jan 25, 2024

@Phenix66 can you check the files marked src-FIXED... in https://github.com/unicode-org/icu/releases/tag/release-74-2 ? those were created with PR #2749 but were waiting for updates to the hashes and signatures to be put in place.

@Phenix66
Copy link
Author

@Phenix66 can you check the files marked src-FIXED... in https://github.com/unicode-org/icu/releases/tag/release-74-2 ? those were created with PR #2749 but were waiting for updates to the hashes and signatures to be put in place.

That did it, judging by the dates of those artifacts I just missed that they were there when I downloaded the archive. Thank you!

@Phenix66 Phenix66 closed this Jan 25, 2024
@srl295
Copy link
Member

srl295 commented Jan 25, 2024

@Phenix66 well, they need to be moved to replace the other ones..

@thesamesam
Copy link

It looks like the fixed signatures are still missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants