Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22556 Prefer cc and c++ compilers #2828

Merged
merged 2 commits into from
Feb 29, 2024
Merged

ICU-22556 Prefer cc and c++ compilers #2828

merged 2 commits into from
Feb 29, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Feb 15, 2024 •
edited by markusicu
Loading

When building icu4c, it defaults to clang instead of gcc when the default compiler, cc / c++, is a symlink to gcc / g++. This is not the expected behavior when building C and C++ code. It appears that this behavior was put in place originally for supporting C++11, which hopefully is no longer such a concern. This PR adjusts the configure.ac for icu4c to prefer the cc and c++ compilers first.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22556
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

roubert
roubert reviewed Feb 15, 2024
View reviewed changes
icu4c/source/configure.ac Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/configure.ac is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .ci-builds/.azure-exhaustive-tests.yml is now changed in the branch
  • .ci-builds/.azure-pipelines.yml is now changed in the branch
  • .github/workflows/icu_valgrind.yml is now changed in the branch
  • .github/workflows/icu4c.yml is now changed in the branch
  • docs/devsetup/cpp/index.md is now changed in the branch
  • docs/devsetup/cpp/linux.md is now changed in the branch
  • docs/processes/release/tasks/healthy-code.md is now changed in the branch
  • docs/processes/release/tasks/integration.md is now changed in the branch
  • icu4c/source/configure is no longer changed in the branch
  • icu4c/source/runConfigureICU is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .ci-builds/.azure-exhaustive-tests.yml is no longer changed in the branch
  • .ci-builds/.azure-pipelines.yml is no longer changed in the branch
  • .github/workflows/icu_valgrind.yml is no longer changed in the branch
  • .github/workflows/icu4c.yml is different
  • docs/devsetup/cpp/index.md is no longer changed in the branch
  • docs/devsetup/cpp/linux.md is no longer changed in the branch
  • docs/processes/release/tasks/healthy-code.md is no longer changed in the branch
  • docs/processes/release/tasks/integration.md is no longer changed in the branch
  • icu4c/source/configure is now changed in the branch
  • icu4c/source/runConfigureICU is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@roubert
Copy link
Member

roubert commented Feb 16, 2024 •
edited
Loading

Oops, it seems we both force pushed at almost exactly the same time, so that I overwrote your changes. Sorry about that. But please take a look at my changes to the workflow configuration, using /clang is only necessary where CC and CXX aren't explicitly set.

@jwillikers
Copy link
Contributor Author

Got it. Sorry about that force-push, I'll add further changes in separate commits to avoid that.

roubert
roubert requested changes Feb 16, 2024
View reviewed changes
docs/devsetup/cpp/index.md Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/devsetup/cpp/index.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

roubert
roubert previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@roubert roubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now, so I now approve this PR, so that it can be merged once the ICU Technical Committee has accepted the ticket.

@jwillikers
Copy link
Contributor Author

I think this looks good now, so I now approve this PR, so that it can be merged once the ICU Technical Committee has accepted the ticket.

Thanks for the review!

@markusicu markusicu self-assigned this Feb 29, 2024
@markusicu
Copy link
Member

@jwillikers could you please rebase this PR? It has a merge conflict now.

We did discuss and approve this change in the ICU-TC meeting today.

jwillikers and others added 2 commits February 29, 2024 12:04
@jwillikers
ICU-22556 Prefer cc and c++ compilers
2e244e4 
When building icu4c, it defaults to clang instead of gcc when the default compiler, cc / c++, is a symlink to gcc / g++.
This not the expected behavior when building C and C++ code.
It appears that this behavior was put in place originally for supporting C++11, which hopefully is no longer such a concern.
This PR adjusts the configure.ac for icu4c to prefer the cc and c++ compilers first.
@roubert @jwillikers
ICU-22556 Update configure files from configure.ac using autoreconf.
c4035d4
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu4c.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jwillikers
Copy link
Contributor Author

@jwillikers could you please rebase this PR? It has a merge conflict now.

We did discuss and approve this change in the ICU-TC meeting today.

@markusicu Done.

roubert
roubert approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@roubert roubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roubert roubert merged commit 137b4c9 into unicode-org:main Feb 29, 2024
100 checks passed
@jwillikers jwillikers deleted the 22556-cc branch February 29, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roubert roubert roubert approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwillikers @CLAassistant @roubert @markusicu