ICU-22152 Uncommented a bunch of commented-out test cases in ULocaleC…

[richgillam]

…ollationTest.TestNameList() and made them pass again.

Checklist

• Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22152
• Required: The PR title must be prefixed with a JIRA Issue number.
• Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
• Required: Each commit message must be prefixed with a JIRA Issue number.
• Issue accepted (done by Technical Committee after discussion)
• Tests included, if applicable
• API docs and/or User Guide docs changed or added, if applicable

[markusicu]

optional:

This hardcodes the English result, and I see that you are changing the test code to temporarily hardcode the default language to be English. This should work.

I wonder if it's worth it. A simpler approach would be to change the expected values that fall back to the default locale to null or "" and have the test code below simply ignore them.

On the other hand, you have done this and you could simply merge it.

[richgillam]

Hardcoding the English results and forcing the default locale to be English seemed like the path of least resistance, so I took it. TBH, I didn't think about using an empty string (or a null) as an indicator to skip the test altogether. I kind of like that, but then you're not testing the "in self" case at all, whereas forcing the default locale to be English does test that logic. On the other hand, getting English in these cases feels really wrong...

I'm inclined to just merge this and call it a day until some other problem comes up or somebody suggests a better change to the underlying code. It sounds like you don't object to that, but I'll leave this PR open until at least the end of the day just in case you change your mind or somebody else weighs in.

[markusicu]

I'm inclined to just merge this and call it a day

+1