Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22261 Add UCONFIG_NO_MF2 flag that can be used to disable MessageFormat 2 functionality #2931

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

catamorphism
Copy link
Contributor

@catamorphism catamorphism commented Mar 27, 2024

This is a followup to #2579 that adds a compile-time flag to disable the MessageFormat 2 functionality.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22261
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@catamorphism
Copy link
Contributor Author

I don't think I have the ability to request reviewers, but paging @markusicu @echeran

I'm also not sure if I should file a separate bug for this. (I just used the same bug number as in #2579 for now.)

richgillam
richgillam previously approved these changes Mar 27, 2024
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't actually test to make sure this works, but it looks good.

Are there MF2 tests in cintltst? If so, they should probably have this guard around them as well.

@catamorphism
Copy link
Contributor Author

Are there MF2 tests in cintltst?

No, only in intltest (which I assumed was the right place, but I hope someone will tell me if it's not :) )

@richgillam
Copy link
Contributor

Are there MF2 tests in cintltst?

No, only in intltest (which I assumed was the right place, but I hope someone will tell me if it's not :) )

I thought you also had C API, and it'd probably be good to do at least a superficial set of tests to make sure your C wrappers do call through appropriately to the C++ implementation. But I definitely wouldn't ask you to do that now, and since you don't have anything there now, I think you're good to go. :-)

@catamorphism
Copy link
Contributor Author

I thought you also had C API, and it'd probably be good to do at least a superficial set of tests to make sure your C wrappers do call through appropriately to the C++ implementation. But I definitely wouldn't ask you to do that now, and since you don't have anything there now, I think you're good to go. :-)

Ah, no -- no C API yet.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm please squash

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu merged commit aff1bba into unicode-org:main Mar 28, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants