Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22758 Make icuexportdata compatible with Unicode 16 normalization #2994

Merged
merged 1 commit into from
May 6, 2024

Conversation

hsivonen
Copy link
Member

@hsivonen hsivonen commented May 2, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22758
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@hsivonen
Copy link
Member Author

hsivonen commented May 2, 2024

ICU4X PR: unicode-org/icu4x#4860

@markusicu markusicu self-assigned this May 2, 2024
@markusicu markusicu requested review from echeran and sffc May 2, 2024 16:48
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm
please squash; you can use the web UI for that

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward algorithm fix, although I haven't taken sufficient time to fully understand the algorithm.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen
Copy link
Member Author

hsivonen commented May 6, 2024

I squashed the changesets.

@markusicu markusicu merged commit 7eaefe0 into unicode-org:main May 6, 2024
97 checks passed
@hsivonen hsivonen deleted the norm16 branch May 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants