Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22721 extend char16_t workaround to cygwin less than 3.5 #3038

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jeremyd2019
Copy link
Contributor

@jeremyd2019 jeremyd2019 commented Jun 13, 2024

uchar.h was added in Cygwin version 3.5.0. Unfortunately, the last version of Cygwin that supported i686 was 3.3.6, and I think 3.4 was the last version that supported Windows 7, so it is still somewhat relevant to a subset of users.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
All committers have signed the CLA.

@FrankYFTang
Copy link
Contributor

we love to review your PR but cannot do so until you sign the CLA.

@cjchapman
Copy link
Member

@jeremyd2019 Thank you for signing the CLA. Will you please create a JIRA ticket for this?

@jeremyd2019
Copy link
Contributor Author

I don't want to create a new account with another service just to create a ticket.

@richgillam richgillam self-assigned this Jun 27, 2024
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM

uchar.h was added in Cygwin version 3.5.0.  Unfortunately, the last version of Cygwin that supported i686 was 3.3.6, so it is still somewhat relevant to a subset of users.
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/unicode/platform.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu changed the title extend char16_t workaround to cygwin less than 3.5 ICU-22721 extend char16_t workaround to cygwin less than 3.5 Sep 24, 2024
@markusicu markusicu merged commit ed68cff into unicode-org:main Sep 24, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants