-
-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22721 Update filtration_test for Python 3.13 #3046
Conversation
The change looks good, and thanks for making the change. I updated the PR with appropriate details. The one last thing required is for the commit message to be prefixed with "ICU-22721" followed by a space. Can you do that? If not, one of us can. FWIW, the easiest way to achieve that is to use the PR Checker Bot. In the table of PR checks, in the row that says "jira-ticket", click the "Details" link. The opportunity to squash the one commit won't affect the code, and in this case won't affect the number of commits on the branch, but you can use it to reword the commit message. |
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
@echeran should be fixed now, all tests passed. |
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Hi @echeran
The author did that. It sounds like otherwise you were ready to approve & merge? @sffc this makes the data build script work on a newer version of Python. |
unittest.makeSuite()
was deprecated in Python 3.11 and removed in 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#unittestChecklist