Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22807 Fix for missing __STDC_FORMAT_MACROS before inttypes.h #3048

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Jun 24, 2024

This is a trivial fix for the issue which we have already addressed earlier. But now another instance of the same has to be fixed. See:
https://unicode-org.atlassian.net/browse/ICU-22807

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22807
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu markusicu self-assigned this Jul 11, 2024
richgillam
richgillam previously approved these changes Jul 19, 2024
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay and matches an earlier fix that we all approved.

Co-authored-by: Markus Scherer <markus.icu@gmail.com>
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2_function_registry.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@barracuda156
Copy link
Contributor Author

barracuda156 commented Aug 27, 2024

@markusicu I have committed your suggestion. (Sorry, should have done that earlier…)

@richgillam Updated and rebased now.

@markusicu markusicu merged commit a4ace3a into unicode-org:main Aug 27, 2024
99 checks passed
@markusicu
Copy link
Member

Thanks @barracuda156 !

@barracuda156 barracuda156 deleted the inttypes branch August 28, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants