Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22912 fix coverity warning in gencnval.c #3203

Merged

Conversation

mike-fabian
Copy link
Contributor

@mike-fabian mike-fabian commented Sep 22, 2024

See: https://unicode-org.atlassian.net/browse/ICU-22912

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22912
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu markusicu self-assigned this Sep 24, 2024
markusicu
markusicu previously approved these changes Sep 24, 2024
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the straightforward fix in old-fashioned code. We should really switch these tools to using std::string -- or our own, internal icu::CharString which has a nice function for appending a path part.

icu4c/source/tools/gencnval/gencnval.c Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/gencnval/gencnval.c is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu merged commit 67b5763 into unicode-org:main Sep 25, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants