ICU-22723 CLDR 46 46 beta3 to main #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DraganBesevic
requested review from
srl295,
mihnita,
macchiati,
markusicu,
pedberg-icu and
richgillam
mihnita
approved these changes
Sep 28, 2024
pedberg-icu
approved these changes
Sep 28, 2024
Thank YOU Mihai. Without you pulling all the changes for per billion, I wouldn't be able to wrap this up |
markusicu
reviewed
Sep 29, 2024
Comment on lines
+4149
to
+4151
| System.out.println(" * Note: In ICU 74 this will be deprecated in favor of"); | ||
| System.out.println(" * createTonne(), which is currently draft but will"); | ||
| System.out.println(" * become stable in ICU 74, and which uses the preferred naming."); |
There was a problem hiding this comment.
@DraganBesevic in a follow-up PR please fix these docs (here and the next function), as discussed.
| // In order to preserve the existing APIs for "metric-ton" we need to | ||
| // add those APIs manually | ||
| if (name.equals("Tonne")) { | ||
| addCXXHForMetricTon(); |
There was a problem hiding this comment.
Why is there nothing like this for Java?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Beta 3 integration for CLDR 46.
Includes updates for tzdata to 2024b and adding new measurement units (duration-night and light-speed).
Known issues:
There is still a problem with per billion unit (a.k.a 1e9). All references are temporarily removed until ICU supports handling this unit: https://unicode-org.atlassian.net/browse/ICU-22781
"metric-ton" was renamed to "tonne", while keeping its internal value within the code the same (METRIC_TON). That confused the tool which automatically creates APIs for units. The tool doesn't create createMetricTon()/getMetricTon() any more. Now it creates createTonne()/getTonne(). I hacked the tool to manually create those existing APIs, there is possible improvement there for the future
ALLOW_MANY_COMMITS=true