Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22938 Remove Known Issue subtags for "und_Hant_CN" #3233

Merged
merged 1 commit into from
Oct 4, 2024
Merged

ICU-22938 Remove Known Issue subtags for "und_Hant_CN" #3233

merged 1 commit into from
Oct 4, 2024

Conversation

sven-oly
Copy link
Contributor

@sven-oly sven-oly commented Oct 3, 2024

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22938
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

macchiati
macchiati reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sven-oly sven-oly marked this pull request as ready for review October 3, 2024 22:38
@sven-oly
Copy link
Contributor Author

sven-oly commented Oct 3, 2024

Please approve if this is OK!

macchiati
macchiati previously approved these changes Oct 3, 2024
View reviewed changes
@sven-oly sven-oly force-pushed the ICU_17981_fix_YUE_known_issue branch from 8e1620c to a48f92c Compare October 3, 2024 23:35
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/util/ULocaleTest.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sven-oly sven-oly merged commit ebbadeb into unicode-org:maint/maint-76 Oct 4, 2024
101 checks passed
@sven-oly sven-oly deleted the ICU_17981_fix_YUE_known_issue branch October 4, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@macchiati macchiati macchiati left review comments

Assignees

@macchiati macchiati

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven-oly @macchiati @markusicu