Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22935 Add ZWG to static currency lists #3234

Conversation

DraganBesevic
Copy link
Contributor

@DraganBesevic DraganBesevic commented Oct 4, 2024

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22935
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Adding ZWG to few static lists.

Followed instructions in https://unicode-org.github.io/icu/processes/cldr-icu.html#5-generate-cldr-production-data-and-convert-for-icu (step 5f).

Also, based on discussion in #2961, there is no lists to update in Java, so only done in C++.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, based on discussion in #2961, there is no lists to update in Java

Actually, based on that discussion, the table in NumericCodeData.java should be updated with the mapping between the letter code and the numeric code, if there is one.

For XCG at the time, there was no known numeric code.

For ZWG, https://en.wikipedia.org/wiki/Zimbabwean_ZiG says that the numeric code is 924.

Please add that.

@markusicu
Copy link
Member

@DraganBesevic
Copy link
Contributor Author

Also, based on discussion in #2961, there is no lists to update in Java

Actually, based on that discussion, the table in NumericCodeData.java should be updated with the mapping between the letter code and the numeric code, if there is one.

For XCG at the time, there was no known numeric code.

For ZWG, https://en.wikipedia.org/wiki/Zimbabwean_ZiG says that the numeric code is 924.

Please add that.

Ooops! Should read it more carefully!

I will update it in the morning

@DraganBesevic
Copy link
Contributor Author

NumericCodeData.java

Actually, Yoshito already updated that

74d5e6d

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DraganBesevic DraganBesevic merged commit 42c2b39 into unicode-org:maint/maint-76 Oct 4, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants