Skip to content

Commit

Permalink
Add note to transient zero-copy violations (#3717)
Browse files Browse the repository at this point in the history
  • Loading branch information
robertbastian authored Jul 21, 2023
1 parent db9301c commit 50b95d7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions provider/datagen/tests/make-testdata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ struct PostcardTestingExporter {
//
// Such types contain some data that was allocated during deserializations
//
// Every entry in this list is a bug that needs to be addressed before ICU4X 1.0.
// Every entry in this list is a bug that needs to be addressed before stabilization.
const EXPECTED_VIOLATIONS: &[DataKey] = &[
// https://github.com/unicode-org/icu4x/issues/1678
icu_datetime::provider::calendar::DateSkeletonPatternsV1Marker::KEY,
Expand All @@ -90,7 +90,9 @@ const EXPECTED_VIOLATIONS: &[DataKey] = &[
// Entries in this list represent a less-than-ideal state of things, however ICU4X is shippable with violations
// in this list since it does not affect databake.
const EXPECTED_TRANSIENT_VIOLATIONS: &[DataKey] = &[
// Regex DFAs need to be validated, which involved creating a BTreeMap
// Regex DFAs need to be validated, which involved creating a BTreeMap.
// If required we could avoid this using one of the approaches in
// https://github.com/unicode-org/icu4x/pulls/3697.
icu_list::provider::AndListV1Marker::KEY,
icu_list::provider::OrListV1Marker::KEY,
icu_list::provider::UnitListV1Marker::KEY,
Expand Down

0 comments on commit 50b95d7

Please sign in to comment.