Calendar Ord follow-ups (#3470)

unicode-org · Jun 6, 2023 · 5c2ea06 · 5c2ea06
1 parent a7785a0
commit 5c2ea06
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
@@ -91,8 +91,9 @@ pub enum AnyCalendar {
     Iso(Iso),
 }
 
+// TODO(#3469): Decide on the best way to implement Ord.
 /// The inner date type for [`AnyCalendar`]
-#[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 #[non_exhaustive]
 pub enum AnyDateInner {
     /// A date for a [`Gregorian`] calendar

diff --git a/components/calendar/src/calendar_arithmetic.rs b/components/calendar/src/calendar_arithmetic.rs
@@ -7,6 +7,7 @@ use core::convert::TryInto;
 use core::marker::PhantomData;
 use tinystr::tinystr;
 
+// Note: The Ord/PartialOrd impls can be derived because the fields are in the correct order.
 #[derive(Copy, Clone, Debug, Hash, Eq, PartialEq, Ord, PartialOrd)]
 #[allow(clippy::exhaustive_structs)] // this type is stable
 pub struct ArithmeticDate<C: CalendarArithmetic> {