Reintroduce derives and exhaustive

unicode-org · Apr 19, 2024 · 7003831 · 7003831
1 parent 226aa13
commit 7003831
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
@@ -1234,7 +1234,7 @@ impl IntoAnyCalendar for IslamicCivil {
         AnyCalendar::IslamicCivil(self)
     }
     fn to_any_cloned(&self) -> AnyCalendar {
-        AnyCalendar::IslamicCivil(self.clone())
+        AnyCalendar::IslamicCivil(self)
     }
     fn date_to_any(&self, d: &Self::DateInner) -> AnyDateInner {
         AnyDateInner::IslamicCivil(*d)
@@ -1258,7 +1258,7 @@ impl IntoAnyCalendar for IslamicTabular {
         AnyCalendar::IslamicTabular(self)
     }
     fn to_any_cloned(&self) -> AnyCalendar {
-        AnyCalendar::IslamicTabular(self.clone())
+        AnyCalendar::IslamicTabular(self)
     }
     fn date_to_any(&self, d: &Self::DateInner) -> AnyDateInner {
         AnyDateInner::IslamicTabular(*d)

diff --git a/components/calendar/src/islamic.rs b/components/calendar/src/islamic.rs
@@ -79,7 +79,8 @@ pub struct IslamicObservational {
 ///
 /// This calendar is a pure lunar calendar with no leap months. It uses month codes
 /// `"M01" - "M12"`.
-#[derive(Clone, Debug, Default)]
+#[derive(Copy, Clone, Debug, Default, Hash, Eq, PartialEq, PartialOrd, Ord)]
+#[allow(clippy::exhaustive_structs)] // unit struct
 pub struct IslamicCivil;
 
 /// Umm al-Qura Hijri Calendar (Used in Saudi Arabia)
@@ -107,7 +108,8 @@ pub struct IslamicUmmAlQura {
 ///
 /// This calendar is a pure lunar calendar with no leap months. It uses month codes
 /// `"M01" - "M12"`.
-#[derive(Clone, Debug, Default)]
+#[derive(Copy, Clone, Debug, Default, Hash, Eq, PartialEq, PartialOrd, Ord)]
+#[allow(clippy::exhaustive_structs)] // unit struct
 pub struct IslamicTabular;
 
 impl IslamicObservational {