You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the discriminant marker is only used in the ZeroTrie enum. It is not used in ZeroTrieSimpleAscii, etc. This is potentially error-prone since a ZeroTrie created from one type can be cast into another type with no way to detect the error in most cases until a debug assertion is hit. It would be safer to write out the discriminant in all cases even when the enum is not used. It also means it is easier to generalize from a specific type to a general type and vice-versa.
Currently the discriminant marker is only used in the ZeroTrie enum. It is not used in ZeroTrieSimpleAscii, etc. This is potentially error-prone since a ZeroTrie created from one type can be cast into another type with no way to detect the error in most cases until a debug assertion is hit. It would be safer to write out the discriminant in all cases even when the enum is not used. It also means it is easier to generalize from a specific type to a general type and vice-versa.
Should do after #4031 and before 1.5
The text was updated successfully, but these errors were encountered: