-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining data structs to fully borrowed #856
Comments
For some structs this will be dependent on #844 |
ICU4X 0.4 is shipped. This got done in some crates but not others. Punting to 0.5. |
In addition to the issues above there are also |
We can also just add it as a list entry there without filing an issue, either works |
Segmenter LSTM data is tracked by #905. That issue is assigned to Ting-yu and scheduled for Sprint C. I added it to the list in the OP. |
Should be #1426 actually |
Here's the current list of non-zc keys:
The first one is rather tricky, I plan to file an issue about it (#1678). The next three are experimental, the last two are #1034 and need LocaleStr (#831) |
list_formatter: #1680 |
All data structs are now zero-copy except for skeletons. LSTM is not yet plugged into the data provider. I'm going to close this issue as completed, since the objective is complete, but ongoing work can be tracked in: |
#876 should stay open until the skeletons / components bag is actually zero-copy (no ZeroFrom hacks). |
Some data structs are capable of zero-copy deserialization. We should migrate all data structs to be this way. This means removing
#[yoke(cloning_zcf)]
where possible (from #847).Separate issues to track each component:
Before closing this issue, the code should be audited to ensure there are no remaining instances of
#[yoke(cloning_zcf)]
, and then this meta-issue can be closed.The text was updated successfully, but these errors were encountered: