Upgrade ICU4X to use tinystr-neo, rename tinystr-neo to tinystr 0.5 #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
dminor,
gregtatum,
nciric,
nordzilla,
sffc,
zbraniecki and
a team
as code owners
| @@ -41,6 +41,18 @@ impl IntoTokenStream for subtags::Language { | |||
| } | |||
| } | |||
|
|
|||
| impl IntoTokenStream for [u8; 4] { | |||
There was a problem hiding this comment.
thought: we could use Bakeable here
Manishearth
removed request for
a team,
dminor,
gregtatum,
nciric and
nordzilla
sffc
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #856
supersedes and closes #1544
fixes #1527
This keeps TinyStr4/8/16 around as compatability shims, we should manually go through the project and audit the uses to use an appropriate N now that we support arbitrary N.