-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc cleanup done for #488 #1059
Merged
Manishearth
merged 5 commits into
unicode-org:main
from
mildgravitas:week_of_precleanup
Sep 17, 2021
Merged
Misc cleanup done for #488 #1059
Manishearth
merged 5 commits into
unicode-org:main
from
mildgravitas:week_of_precleanup
Sep 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-time 5 months ago but the test still referred to the old file.
mildgravitas
requested review from
gregtatum,
nordzilla,
sffc and
zbraniecki
as code owners
September 16, 2021 13:23
zbraniecki
previously approved these changes
Sep 16, 2021
Manishearth
reviewed
Sep 16, 2021
Manishearth
previously approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, minor nit
gregtatum
previously approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean-ups.
mildgravitas
dismissed stale reviews from gregtatum, Manishearth, and zbraniecki
via
September 17, 2021 13:45
9b43425
Manishearth
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.