Adds UnicodePropertyMapV1 data struct for enumerated properties #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1162 should help with the custom derives. |
TrieType no longer exists, so we don't need an awkward name for TrieTypeEnum.
iainireland
force-pushed
the
cpt-provider-struct
branch
from
3519819
to
0087396
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
echeran
previously approved these changes
Oct 18, 2021
| } | ||
| } | ||
|
|
||
| // impl<'a, T: TrieValue> ZeroCopyFrom<CodePointTrie<'a, T>> for CodePointTrie<'static, T> { |
There was a problem hiding this comment.
question: Can this be removed?
I'm guessing from the commit that merged in changes from PR #1162 that this can be removed, just checking. If you want, I can remove this in my followup PR, just lmk.
There was a problem hiding this comment.
Oops, yeah, didn't mean to push this.
sffc
requested changes
Oct 18, 2021
sffc
reviewed
Oct 18, 2021
Co-authored-by: Shane F. Carr <shane@unicode.org>
2 tasks
sffc
changed the title
sffc
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my initial draft. Most of the interesting stuff is in
utils/codepointtrie/src/provider.rs.