Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo-all-features for all feature sets (incl. no features) #169

Closed
wants to merge 5 commits into from

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Jul 8, 2020

Summary:

  • Using cargo-all-features appears to build and test against all subsets of features (including no features) as expected
  • The build step (cargo build-all-features) ends early with an error
  • The test step (cargo test-all-features), when run locally, shows some of the combinations in its output
  • The reported errors may not be the exhaustive list, since the process exits early on error
  • example workflow run

Fixes #63

Selected lines from build run:

    Building crate=icu-data-provider features=[]

error[E0432]: unresolved import `std::error`
  --> components/data-provider/src/lib.rs:16:10
   |
16 | use std::error::Error;
   |          ^^^^^ help: a similar path exists: `downcast_rs::std::error`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `icu-data-provider`.

Selected lines from test run:

     Testing crate=icu4x features=[]

     Testing crate=icu-data-provider-json features=[]

     Testing crate=icu-data-provider-json features=[std]

     Testing crate=icu features=[]

     Testing crate=icu-data-provider features=[]

error[E0432]: unresolved import `std::error`
  --> components/data-provider/src/lib.rs:16:10
   |
16 | use std::error::Error;
   |          ^^^^^ help: a similar path exists: `downcast_rs::std::error`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `icu-data-provider`.

@echeran echeran requested review from zbraniecki and sffc July 8, 2020 04:22
@echeran echeran requested a review from a team as a code owner July 8, 2020 04:22
@coveralls
Copy link

coveralls commented Jul 8, 2020

Pull Request Test Coverage Report for Build 86273e465d7b795d63847d8239ce4fe159b3b2c7-PR-169

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.199%

Totals Coverage Status
Change from base Build e555f25bad0ae5af43dda697328c787944a4252e: 0.0%
Covered Lines: 688
Relevant Lines: 789

💛 - Coveralls

@sffc
Copy link
Member

sffc commented Jul 10, 2020

I'm confused. The diff in this PR shows you adding the Clippy check that you added in #161.

@echeran
Copy link
Contributor Author

echeran commented Jul 10, 2020

Hmm, I got the source branch misconfigured -- I should have used echeran:ci-all-features. This PR mistakenly uses echeran:master as the source branch b/c it's the only easy way to do iterative testing of Github Actions on a personal fork without disrupting an open PR. I'll re-create this PR but with the correct branch configured.

@echeran
Copy link
Contributor Author

echeran commented Jul 10, 2020

Closing & moving this PR over to #172 .

@echeran echeran closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running tests with different feature sets / architectures
4 participants