-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move collator and normalizer from experimental to components #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass normalization conformance tests. Includes regenerated data that fixes an off-by-one error at the decomposition table supplement boundary. Closes unicode-org#1979
Depends on #2087 to have all the TOML files is the zip exported from ICU4C. |
Co-authored-by: Elango <elango@unicode.org>
Co-authored-by: Elango <elango@unicode.org>
Co-authored-by: Elango <elango@unicode.org>
hsivonen
requested review from
Manishearth,
sffc,
a team and
robertbastian
as code owners
July 11, 2022 16:50
hsivonen
requested review from
sffc
and removed request for
sffc,
Manishearth and
robertbastian
July 11, 2022 16:51
Going to refresh the CI |
sffc
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.