Custom eq for ResourceKey #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Jul 11, 2022
sffc
reviewed
Jul 11, 2022
| match key { | ||
| CardinalV1Marker::KEY => self | ||
| .source | ||
| if key == CardinalV1Marker::KEY { |
There was a problem hiding this comment.
Nit: Why did you change this function? I think match on ResourceKey should still work (just less efficient)
There was a problem hiding this comment.
Nope, you can only match on const values that have a derived PartialEq.
There was a problem hiding this comment.
This is why I didn't want to add fields to ResourceKey
There was a problem hiding this comment.
Nit (optional): Can we keep them as match but match on the string path, creating local constants? Then, if/when Rust adds support for { constexpr } as Manish suggested, we can migrate to it.
There was a problem hiding this comment.
I considered that but the if/else is more concise
sffc
reviewed
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.