Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding components root and empty workspace config #29

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Conversation

nciric
Copy link
Contributor

@nciric nciric commented Apr 13, 2020

Going with the assumption that we'll use workspaces for this project. Detailed explanation of workspace approach (benefits and drawbacks) can be found in official docs.

For example, all crates in a workspace have the same dependency versions, and all of the build outputs are in the same folder.

This is related to issue #18

Manishearth
Manishearth previously approved these changes Apr 13, 2020
@Manishearth
Copy link
Member

Wait, the cargo.toml should probably be at the top level.

@nciric
Copy link
Contributor Author

nciric commented Apr 13, 2020

Wait, the cargo.toml should probably be at the top level.

But it is - at the top of components. Do you think it should be in the root of the repository?
I thought all of the Rust code would go under components, and none directly under root.

@nciric
Copy link
Contributor Author

nciric commented Apr 13, 2020

Wait, the cargo.toml should probably be at the top level.

But it is - at the top of components. Do you think it should be in the root of the repository?
I thought all of the Rust code would go under components, and none directly under root.

Ah, you probably think that components won't be the only top folder - for example wrappers can be another, but they are all related in one workspace. In that case it makes sense.

@Manishearth
Copy link
Member

Yeah there's very little reason to have multiple workspaces in a repo

@nciric
Copy link
Contributor Author

nciric commented Apr 13, 2020

Yeah there's very little reason to have multiple workspaces in a repo

Done, PTAL

@nciric nciric merged commit f6a8633 into master Apr 13, 2020
@zbraniecki zbraniecki deleted the workspace branch June 29, 2020 01:27
aethanyc added a commit to aethanyc/icu4x that referenced this pull request Oct 27, 2021
The TOML file was obtained from Azure artifact archive from commit
2921a81ee4c67459ff455e31c599e7d7a09086ab titled "ICU-21811 TZ update
2021a (2021e)" on maint/maint-70 branch. Here we import the "small"
flavor of the TOML files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants