Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICU Meta Package for 0.1 #306

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Conversation

zbraniecki
Copy link
Member

Adding icu meta-crate with basic features from all available components, examples and docs.

I'm using icu crate since it seems like that's the consensus on what people prefer, but we are also squatting icu4x package name in case people prefer that.

@zbraniecki zbraniecki mentioned this pull request Oct 6, 2020
@coveralls
Copy link

coveralls commented Oct 6, 2020

Pull Request Test Coverage Report for Build ff71f4da301fe3995ce7d1ffb14d904e1fca8bf9-PR-306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.652%

Totals Coverage Status
Change from base Build 6d6bcea21678159d29f26c5bd02bb9ce420001b4: 0.0%
Covered Lines: 2891
Relevant Lines: 3723

💛 - Coveralls

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/icu/src/lib.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@zbraniecki zbraniecki marked this pull request as ready for review October 6, 2020 19:14
@zbraniecki zbraniecki requested a review from a team as a code owner October 6, 2020 19:14
@zbraniecki
Copy link
Member Author

This is ready for review.

It's a shallow re-export of datetime, pluralrules, locale and unicodeset with some intro docs.

I kept the icu package rather than icu4x for now, and I did pull some tests and an example that we'll unify around testdata once we have a single location for it.

When we enable locale macros I'd like to enable that feature by default in this crate, because I think that most people should use it.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/icu/examples/tui.rs is different
  • components/icu/src/lib.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/icu/examples/tui.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/icu/examples/tui.rs is different
  • components/icu/tests/fixtures/data/icu4x/dates/gregory@1/en.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/dates/gregory@1/pl.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/dates/manifest.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/manifest.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/ar.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/cs.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/de.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/en.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/es.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/fr.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/it.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/pl.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/sk.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/uk.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/cardinal@1/zh.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/ar.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/cs.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/de.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/en.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/es.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/fr.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/it.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/pl.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/sk.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/uk.json is no longer changed in the branch
  • components/icu/tests/fixtures/data/icu4x/plurals/ordinal@1/zh.json is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc previously approved these changes Oct 9, 2020
@sffc sffc mentioned this pull request Oct 9, 2020
@zbraniecki zbraniecki merged commit fa8e1f4 into unicode-org:master Oct 9, 2020
@zbraniecki zbraniecki deleted the icu-meta branch October 19, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants