LSTM error paths #3270
Merged
LSTM error paths #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
aethanyc,
makotokato and
sffc
as code owners
Closed
sffc
approved these changes
Apr 7, 2023
Comment on lines
+267
to
+268
| // Create error for logging | ||
| DataError::custom("No segmentation model for language").with_display_context( |
There was a problem hiding this comment.
Thought: Actually I kind-of like the idea of performing logging through the icu_provider crate. It keeps all the needed machinery in one place. We should probably add our own logging macro that we export from icu_provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapsed
DictionaryandLstmPayloadsinto one struct,ComplexPayloads. This struct is where the grapheme segmentation data can live, which is required by both code paths and introduced fallibility before. It also removes previously unhandled error cases from the core logic, so that we can log when we encounter an actual error (missing data for a language).This also gives us a location for script properties data, which is needed by the complex code path.