Revert datagen fs feature #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-org#3354)" This reverts commit 98a47f3.
Manishearth
requested review from
sffc,
robertbastian and
a team
as code owners
robertbastian
previously approved these changes
Apr 20, 2023
|
Either way, go ahead and yank 1.2.2. No need to wait for that |
|
Also add #3355 to the changelog before you release anything. |
|
Let's discuss this a bit in the meeting |
|
yanked, yoinked, and yeeted |
Manishearth
changed the title
robertbastian
approved these changes
Apr 20, 2023
sffc
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3354, we don't actually need it that much (it doesn't have an effect on
icu_provider"sync") and we landed it in a way that was accidentally breakingThis PR will also involve yanking
icu_datagen1.2.2Alternative to #3357