Add some Debug implementations in datagen #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around the `missing_debug_implementations` regression in rust-lang/rust#111359 . I don't know if that will be fixed soon; I spent some time investigating it and have an idea of what's going on but not enough to fix it (and don't want to spend more time on this right now). So for now, let's just listen to the lint and add these impls.
|
This has a merge conflict with #3386 which I've been trying to get merged for a week. |
|
I'm not in a rush. Also feel free to just roll these changes into it. |
robertbastian
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the
missing_debug_implementationsregression in rust-lang/rust#111359 . I don't know if that will be fixed soon; I spent some time investigating it and have an idea of what's going on but not enough to fix it (and don't want to spend more time on this right now). So for now, let's just listen to the lint and add these impls.