Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More casemapping fixes #3544

Merged
merged 8 commits into from
Jun 16, 2023
Merged

More casemapping fixes #3544

merged 8 commits into from
Jun 16, 2023

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jun 16, 2023 •
edited
Loading

Part of #3234

  • Exposed Writeable methods (tell me what to call them please)
  • no_std and library boilerplate
  • Case closure methods

@Manishearth Manishearth requested a review from a team as a code owner June 16, 2023 06:15
@Manishearth Manishearth mentioned this pull request Jun 16, 2023
Closed
31 tasks
@Manishearth Manishearth force-pushed the casemapping-fixes branch 2 times, most recently from 3389a1e to b711a98 Compare June 16, 2023 07:55
@Manishearth Manishearth requested a review from sffc as a code owner June 16, 2023 07:55
robertbastian
robertbastian approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names lgtm

@Manishearth Manishearth merged commit 244a499 into unicode-org:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @robertbastian