Baked data for icu_normalizer
#3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc and
Manishearth
and removed request for
hsivonen and
echeran
robertbastian
force-pushed
the
normalizer
branch
from
6ac96a0
to
bfc4842
Compare
Manishearth
approved these changes
Jun 22, 2023
Manishearth
previously approved these changes
Jun 22, 2023
sffc
reviewed
Jun 23, 2023
| ); | ||
| #[doc(hidden)] | ||
| #[cfg(all(feature = "experimental", feature = "data"))] | ||
| pub const fn new_uts46_decomposed_without_ignored_and_disallowed() -> Self { |
There was a problem hiding this comment.
Nit: You should be able to auto-generate this, right? It's just calling _unstable with crate::provider::Baked? I guess the difference is that you avoid the singleton check; is that it?
There was a problem hiding this comment.
Auto generated constructors will go through DataProvider::load and be fallible. This uses singletons and is infallible.
robertbastian
force-pushed
the
normalizer
branch
2 times, most recently
from
dc68797
to
39a1072
Compare
robertbastian
force-pushed
the
normalizer
branch
from
39a1072
to
347dc8a
Compare
sffc
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2945
Based on #3565