s/data/compiled_data #3603
Merged
s/data/compiled_data #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
filmil,
pdogr,
snktd,
eggrobin,
nordzilla,
aethanyc,
makotokato,
zbraniecki,
hsivonen,
echeran,
dminor,
gregtatum and
a team
as code owners
eggrobin
approved these changes
Jun 30, 2023
sffc
approved these changes
Jun 30, 2023
| @@ -44,7 +44,7 @@ databake = { version = "0.1.3", path = "../../utils/databake", optional = true, | |||
| serde = { version = "1.0", default-features = false, features = ["derive", "alloc"], optional = true } | |||
|
|
|||
| icu_collator_data = { version = "~1.3.0", path = "data", optional = true } | |||
| icu_locid_transform = { version = "1.2.0", path = "../../components/locid_transform", features = ["data"], optional = true } | |||
| icu_locid_transform = { version = "1.2.0", path = "../../components/locid_transform", features = ["compiled_data"], optional = true } | |||
There was a problem hiding this comment.
Nit (here and elsewhere): This is a bit misleading; I would prefer if you included icu_locid_transform without compiled_data up here and then included it with the feature down in the compiled_data section:
icu_locid_transform = { version = "1.2.0", path = "../../components/locid_transform", optional = true }
...
compiled_data = ["dep:icu_collator_data", "icu_normalizer/compiled_data", "dep:icu_locid_transform", "icu_locid_transform/compiled_data"]
There was a problem hiding this comment.
This is preexisting and I'd like to keep this PR a clean rename.
Manishearth
approved these changes
Jun 30, 2023
robertbastian
removed request for
aethanyc,
filmil,
dminor,
zbraniecki,
hsivonen,
echeran,
makotokato,
gregtatum,
pdogr,
nordzilla and
snktd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2945