Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baked data for icu_capi #3607

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Baked data for icu_capi #3607

merged 4 commits into from
Jul 4, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jun 30, 2023 •
edited
Loading

@robertbastian robertbastian changed the title compiled_data FFI Baked data for icu_capi Jul 3, 2023
@robertbastian robertbastian marked this pull request as ready for review July 3, 2023 15:36
@robertbastian robertbastian requested a review from a team as a code owner July 3, 2023 15:36
sffc
sffc requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also state in the PR title (and commit message) that this is removing the provider_test and any_provider features on icu_capi

tools/ffi_coverage/src/allowlist.rs Outdated Show resolved Hide resolved
ffi/diplomat/Cargo.toml Show resolved Hide resolved
@robertbastian robertbastian requested a review from sffc July 4, 2023 18:28
@sffc sffc changed the title Baked data for icu_capi Baked data for icu_capi; removes provider_test and any_provider features Jul 4, 2023
@sffc sffc mentioned this pull request Jul 4, 2023
Merged
@robertbastian robertbastian changed the title Baked data for icu_capi; removes provider_test and any_provider features Baked data for icu_capi Jul 4, 2023
@robertbastian
Copy link
Member Author

Please also state in the PR title (and commit message) that this is removing the provider_test and any_provider features on icu_capi

This is not removing the features, as that would be a semver breakage. It's changing the behaviour of create_test.

@robertbastian robertbastian merged commit 8803d5d into unicode-org:main Jul 4, 2023
@robertbastian robertbastian deleted the ffi branch July 5, 2023 12:27
Manishearth
Manishearth reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: clever solution with the macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth left review comments

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth