Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for icu_harfbuzz #3628

Closed
wants to merge 5 commits into from
Closed

Cleanup for icu_harfbuzz #3628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c874f7
again
robertbastian Jul 3, 2023
23ad124
dep
robertbastian Jul 4, 2023
d5b1cac
Merge branch 'main' into hb
robertbastian Jul 4, 2023
289378b
fix
robertbastian Jul 4, 2023
6e6e641
tidy
robertbastian Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion experimental/harfbuzz/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ displaydoc = { version = "0.2.3", default-features = false }
tinystr = { version = "0.7.1", path = "../../utils/tinystr", default-features = false }

[dev-dependencies]
icu_testdata = { path = "../../provider/testdata" }
harfbuzz = { version = "0.4.0" }

[features]
Expand Down
3 changes: 1 addition & 2 deletions experimental/harfbuzz/README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions experimental/harfbuzz/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,10 @@
//!
//! ```
//! use harfbuzz::{Buffer, Direction, sys};
//! use icu_harfbuzz::new_hb_unicode_funcs_unstable;
//!
//! let mut b = Buffer::with("مساء الخير");
//!
//! let unicode_funcs = new_hb_unicode_funcs_unstable(&icu_testdata::unstable()).unwrap();
//! let unicode_funcs = icu_harfbuzz::new_hb_unicode_funcs().unwrap();
//!
//! // NOTE: This currently requires `unsafe` code. For progress toward a safe abstraction, see:
//! // <https://github.com/servo/rust-harfbuzz/pull/197>
Expand Down