Remove testdata #3635
Merged
Remove testdata #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
a team,
hsivonen,
echeran,
dminor,
zbraniecki,
gregtatum and
nordzilla
as code owners
robertbastian
removed request for
a team,
dminor,
zbraniecki,
hsivonen,
echeran,
gregtatum and
nordzilla
sffc
previously approved these changes
Jul 5, 2023
Comment on lines
+24
to
+25
| "!tests/data/json/**/*", | ||
| "!tests/data/postcard/**/*", |
There was a problem hiding this comment.
Just flagging this; I assume the tests still run without this data?
There was a problem hiding this comment.
This data is not used by tests. It just exists so we can look at diffs on GitHub (fingerprints and JSON contents).
| in icu_datagen. If not, it's likely that japanese.rs in icu_datagen will need \ | ||
| to be updated to handle the data changes. Once done, be sure to regenerate datetime/symbols@1 as well if not \ | ||
| doing so already" | ||
| changed in an incompatible way, or there is a new Japanese era. Run \ |
| LocaleInclude::Explicit(icu_testdata::locales().into_iter().collect()); | ||
| options | ||
| }, | ||
| Default::default(), |
There was a problem hiding this comment.
Question: you can do this because the default behavior is to enumerate the directories to find the locales?
There was a problem hiding this comment.
Yes, default behaviour is all locales.
sffc
previously approved these changes
Jul 5, 2023
Manishearth
previously approved these changes
Jul 5, 2023
Manishearth
previously approved these changes
Jul 6, 2023
Manishearth
previously approved these changes
Jul 6, 2023
|
Discussion:
LGTM: @Manishearth @sffc @robertbastian |
Manishearth
approved these changes
Jul 6, 2023
sffc
approved these changes
Jul 7, 2023
Comment on lines
+53
to
+54
| let out_root = | ||
| std::path::Path::new(std::env!("CARGO_MANIFEST_DIR")).join("../../provider/datagen"); |
There was a problem hiding this comment.
Thought: Not very happy about this using a relative path, but it is in a no-publish crate, so okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3529