Use UnvalidatedStr for casemap unfold keys #3690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two other strings in casemap on data that isn't hit often: the exceptions data and the unfold values are also
str
s.@sffc @robertbastian what do you think of making those UnvalidatedStrs as well? We could GIGO when they're not. The nice thing is that people won't pay upfront costs about data that is not used often.
Unfold data is not too big, exceptions data is kinda big but also not all of it is rare to hit.
The main issue is that in the exception data multiple calls to
get_char_slot()
etc would have to reparse the string. But the string is likely to be small anyway.