Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagen API improvements #3705

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Datagen API improvements #3705

merged 4 commits into from
Jul 20, 2023

Conversation

robertbastian
Copy link
Member

#3564

  • Paths in config files are now interpreted relative to the config file
  • The config serde spec is now cfg-free, as that turned out to be quite confusing. The CLI now reports missing features errors
  • Legacy testdata gen is now run on CI
  • provider_baked::Options::use_separate_crates now defaults to true, as that's the mode required for compiled data
    • the config uses use_meta_crate, as we want to default to false
  • All hello world provider testdata is now generated from configs and checked in CI

@robertbastian robertbastian requested review from a team, Manishearth and sffc as code owners July 19, 2023 14:05
Manishearth
Manishearth previously approved these changes Jul 20, 2023
@robertbastian robertbastian merged commit c2064d9 into unicode-org:main Jul 20, 2023
23 checks passed
@robertbastian robertbastian deleted the dg branch July 20, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants