-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagen: Consume CLDR-JSON resources keyed with default script #3772
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5a242bc
Create LocaleResource and use it in the numbers JSON
sffc 089a6f0
Switch ca.rs to use LocaleResource with `pub type Resource`
sffc a44a138
Switch numbers.rs to use a typedef
sffc a65b178
Migrate date_fields, exemplar_chars, and list_patterns
sffc 80b5618
clippy
sffc c3239b9
fmt
sffc 4c3c133
clippy
sffc 60576fc
Migrate time_zone_names.rs
sffc f084546
Migrate displaynames
sffc ee712cb
Load fallback_data into CldrCache
sffc 9475c4d
WIP
sffc 66f4dda
Hook up LocaleExpander in CldrCache
sffc 73f0c64
Fix LocaleExpander::try_new_with_any_provider
sffc 3bd6a57
Load both payloads for LocaleExpander
sffc 816f07e
Test for b91de52edf2cedbda5e1b64433091cf63ec7b56c
sffc 3d1065e
cargo make bakeddata
sffc b83db98
Fix file_exists
sffc 4f7f918
fmt
sffc 07ed798
cargo make bakeddata for displaynames
sffc b3c376f
Make script fallback quieter by checking for file_exists first
sffc 2796cd4
lazy
robertbastian 8f23339
Merge branch 'main' into zhHansSG
sffc f0d1fcc
Merge branch 'main' into zhHansSG
sffc d3ea23f
Remove duplicate once_cell dependency
sffc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manishearth to approve the new dependency. (We now have multiple places where it is useful)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to not have two lazy initialization dependencies, we should either use
lazy_static
everywhere oronce_cell
everywhere.Slight preference for the latter since 1.70 has it in std
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with #3777 being 1.3 blocking (I'm fine with this landing first)