Titlecasing renames #3843
Merged
Titlecasing renames #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Aug 10, 2023
Manishearth
force-pushed
the
leading-adjustment
branch
from
e0556e3
to
2a11b75
Compare
sffc
approved these changes
Aug 11, 2023
31 tasks
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements discussions from #3801 (fixes #3801). Does the following:
HeadAdjustmenttoLeadingAdjustment {Auto, None, ToCased}TailCasingtoTrailingCase {Lowercase, Unchanged}_legacyCaseMapper API to_with_only_case_data_legacyTitlecaseMapperAPIs (can be re-added later)This is also the final open stabilization issue, so I'm going to mark this as fixing #3234 . (note for reviewers: if you think there are still outstanding items, feel free to edit the magic issue-closing comment out of this PR body)