Add formatting for Dangi calendar
#3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atcupps
requested review from
a team,
sffc,
robertbastian,
Manishearth,
zbraniecki,
gregtatum and
nordzilla
as code owners
Manishearth
reviewed
Aug 11, 2023
| @@ -25,6 +25,9 @@ | |||
| "ja-u-ca-japanese": "令和2年1月21日火曜日 8:25:07", | |||
| "en-u-ca-coptic": "Tuesday, Toba 12, 1736 ERA1, 08:25:07", | |||
| "fr-u-ca-coptic": "mardi 12 toubah 1736 après Dioclétien 08:25:07", | |||
| "en-u-ca-dangi": "Tuesday, Twelfth Month 27, 2019((cyclic year: 36)), 08:25:07", | |||
| "fr-u-ca-dangi": "2019((cyclic year: 36)) shí’èryuè 27, mardi 08:25:07", | |||
| "ko-u-ca-dangi": "2019년((cyclic year: 36)년) 12월 27일 화요일 08:25:07", | |||
There was a problem hiding this comment.
observation: the double parentheses are because we're using parentheses as fake formatting patterns until #3761 is fixed
Manishearth
approved these changes
Aug 11, 2023
Manishearth
removed request for
zbraniecki,
gregtatum,
robertbastian and
nordzilla
sffc
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.