Add initialisation macro to baked output #4014
Conversation
robertbastian
requested review from
a team,
sffc,
Manishearth,
pdogr,
snktd,
eggrobin,
nordzilla,
aethanyc,
makotokato,
zbraniecki,
hsivonen,
echeran,
dminor and
gregtatum
as code owners
robertbastian
removed request for
aethanyc,
dminor,
zbraniecki,
hsivonen,
echeran,
makotokato,
gregtatum,
eggrobin,
pdogr,
nordzilla and
snktd
| @@ -1,37 +1,18 @@ | |||
| // @generated | |||
| include!("macros.rs"); | |||
| /// Implement `DataProvider<M>` on the given struct using the data | |||
There was a problem hiding this comment.
I decided these should not be public, only locally usable.
There was a problem hiding this comment.
Why did you decide that? I thought we had decided that these macros were public API of the data crates. We just talked about that together earlier this week.
There was a problem hiding this comment.
They haven't been public before, and impl_data_provider doesn't work reexported because it cannot address the individual macros (well, it can, but then it wouldn't work locally anymore). AnyProvider can be implemented through the impl_dynamic_data_provider macro.
There was a problem hiding this comment.
Oh I see, this is impl_data_provider. But shouldn't impl_any_provider still work reexported? It doesn't reference macros, only types. impl_dynamic_data_provider needs a list of keys.
There was a problem hiding this comment.
I don't think it should if impl_data_provider isn't. Remember we don't like AnyProviders anymore.
| @@ -1,37 +1,18 @@ | |||
| // @generated | |||
| include!("macros.rs"); | |||
| /// Implement `DataProvider<M>` on the given struct using the data | |||
Fixes #3535