Update ICU component version numbers #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
robertbastian,
Manishearth,
snktd,
eggrobin,
aethanyc,
makotokato,
dminor,
zbraniecki,
gregtatum,
nordzilla and
a team
as code owners
sffc
removed request for
a team,
aethanyc,
dminor,
zbraniecki,
makotokato,
gregtatum,
eggrobin,
nordzilla and
snktd
sffc
force-pushed
the
Update-icu-component-version-numbers
branch
from
47280c7 to
3fafa8f
Compare
Manishearth
previously approved these changes
Sep 22, 2023
sffc
force-pushed
the
Update-icu-component-version-numbers
branch
from
3fafa8f to
dfdd782
Compare
Manishearth
previously approved these changes
Sep 23, 2023
sffc
dismissed
Manishearth’s stale review
The merge-base changed after approval.
sffc
force-pushed
the
Update-icu-component-version-numbers
branch
from
dfdd782 to
7a68ea1
Compare
Manishearth
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4065
A few things I noticed:
zerotrie,tzif, and some others are utils, but they didn't get done in the utils upgrades because they are under the experimnetal directory. I updated them here.icu_displaynameshad some changes to the signatures of the data structs without apparently changing the data structs themselves, but to err on the side of caution I bumped it from 0.10 to 0.11icu_relativetimeandicu_compactdecimalappeared to be fully additive so I bumped them on the patch version