Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ZeroVec T: Bake bound. #4080

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Remove ZeroVec T: Bake bound. #4080

merged 2 commits into from
Sep 22, 2023

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 22, 2023

zervec and zervec derive to 0.9.6

#4065

@sffc
Remove ZeroVec T: Bake bound.
0697efb 
zervec and zervec derive to 0.9.6
@sffc sffc requested review from Manishearth and a team as code owners September 22, 2023 21:34
@sffc sffc requested review from robertbastian and removed request for a team September 22, 2023 21:34
@sffc
Copy link
Member Author

sffc commented Sep 22, 2023

tutorials-cratesio is failing because of this, but should be fixed after we publish

@Manishearth Manishearth merged commit 6a787bb into unicode-org:main Sep 22, 2023
24 of 25 checks passed
@Manishearth
Copy link
Member

Published and yanked

Manishearth added a commit to Manishearth/icu4x that referenced this pull request Sep 22, 2023
@Manishearth
Revert "Remove ZeroVec T: Bake bound. (unicode-org#4080)"
d3c000b 
This reverts commit 6a787bb.
@sffc sffc deleted the bake-bound branch September 22, 2023 23:46
@robertbastian
Copy link
Member

Why was this done?

@sffc
Copy link
Member Author

sffc commented Sep 25, 2023 •
edited
Loading

After we uploaded zerovec 0.9.5 with T: Bake, icu_timezone@1.2 started failing to compile. This PR fixed that problem by removing that breaking change in 0.9.6, and then we moved the breaking zerovec change to 0.10.0

@robertbastian
Copy link
Member

I see, so this has been reverted in another PR?

@sffc
Copy link
Member Author

sffc commented Sep 25, 2023

T: Bake was added back in #4081 which updated zerovec to 0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@robertbastian robertbastian Awaiting requested review from robertbastian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @Manishearth @robertbastian