Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't error on likelySubtags entries that change subtags #4131

Closed
wants to merge 1 commit into from
Closed

Don't error on likelySubtags entries that change subtags #4131

wants to merge 1 commit into from

Conversation

Manishearth
Copy link
Member

Part of #4130

@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label Oct 6, 2023
sffc
sffc requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not convinced. The locale canonicalizer and locale fallbacker code has this invariant embedded deeply. Erroring is probably the right behavior.

@sffc sffc requested a review from zbraniecki October 6, 2023 17:46
@robertbastian
Copy link
Member

If this stays an error it should be a DataError, panicking depending on input data is messy.

See https://github.com/unicode-org/icu4x/blob/main/components/list/src/patterns.rs#L125-L128

@robertbastian robertbastian removed their request for review October 21, 2023 13:56
@sffc
Copy link
Member

sffc commented Nov 2, 2023

Discuss with:

@sffc sffc added the discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band label Nov 2, 2023
@sffc
Copy link
Member

sffc commented Dec 29, 2023

Discussed on 2023-11-27 in the CLDR design meeting

https://unicode-org.atlassian.net/browse/CLDR-17251

"OK (and good) to add a constraint on the data file, that prevents each target field from being different from the source field except for the documented cases: und, Zzzz, ZZ, empty, macroregion. This would be in the LDML spec, and in a CLDR unit test. Also document that special treatment of iw, … and look at wording of #2 and #3"

So I think this PR can be closed.

@sffc sffc closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc requested changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki

Assignees
No one assigned
Labels
discuss Discuss at a future ICU4X-SC meeting discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manishearth @robertbastian @sffc