Datagen: Add workaround for variants table in CLDR 44 #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
srl295 and
echeran
and removed request for
Manishearth and
robertbastian
echeran
approved these changes
Oct 15, 2023
|
If this is confirmed as a bug I'd rather wait for the fix to land in CLDR-JSON. |
|
Not needed, data was fixed |
we have tickets for dealing with this as well in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4155
CLDR 44 BETA contains data such as
{ "main": { "vec": { "identity": { "version": { "_cldrVersion": "44" }, "language": "vec" }, "localeDisplayNames": { "variants": { "1901": {}, "1994": {}, "1996": "ortografìa todesca de’l 1996", "1606NICT": "franseze mezo tardivo fin el 1606",This may be a bug, but in the mean time I created some code to work around it. See:
https://unicode-org.atlassian.net/browse/CLDR-17171