Implement Any/BufferProvider for some smart pointers
#4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Nov 8, 2023
| } | ||
| } | ||
|
|
||
| #[cfg(target_has_atomic = "ptr")] |
There was a problem hiding this comment.
thought: hm, in general we haven't been careful about this, but I guess it doesn't hurt to start?
There was a problem hiding this comment.
I think in other places we've been using #[cfg(feature = "std")] for gating Arc. I'm not sure which of these is better though. I think the main thing is to not mess up the compilation of targets like wasm32-unknown-unknown. If this works without needing the std feature then that's great and we should use this pattern in more places.
Manishearth
approved these changes
Nov 9, 2023
sffc
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows storing them as a
Box<dyn Any/BufferProvider>without using a wrapper type that implements the trait.