Fix datagen with --segmenter-lstm-root #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
previously approved these changes
Nov 13, 2023
|
Ah, please add to changelog |
sffc
previously approved these changes
Nov 13, 2023
|
I think cherry-picking is a great reason to have the changelog in the same PR. You might have to resolve a diff, but the changelog entry comes with the commit. In the PR that bumps the version you then move the entry from unreleased to that version number. |
|
ok, I'll just need to fix the merge conflict if we do it that way. it's fine. |
Manishearth
force-pushed
the
datagen-seglstm-arg
branch
from
0551d70
to
9c90987
Compare
robertbastian
approved these changes
Nov 14, 2023
sffc
pushed a commit
to sffc/omnicu
that referenced
this pull request
Nov 14, 2023
Encountered fun errors where datagen worked fine with `--icuexport-root` but not when you also pass it `--segmenter-lstm-root`; with the segmenter paths overriding icuexportdata. Thanks to @robertbastian for finding where the bug was. (cherry picked from commit 374dafa) Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered fun errors where datagen worked fine with
--icuexport-rootbut not when you also pass it--segmenter-lstm-root; with the segmenter paths overriding icuexportdata.Thanks to @robertbastian for finding where the bug was.