Split MeasureUnit into MeasureUnitParser and MeasureUnit
#4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
changed the title
MeasureUnitParser
|
🎉 All dependencies have been resolved ! |
sffc
previously approved these changes
Dec 8, 2023
| impl MeasureUnit { | ||
| impl<'data> MeasureUnitParser<'data> { | ||
| /// Creates a new MeasureUnitParser from a ZeroTrie payload. | ||
| pub fn new(zerotrie_payload: &'data ZeroTrie<ZeroVec<'data, u8>>) -> Self { |
There was a problem hiding this comment.
issue: the public API should construct this from the data struct, through a provider. this looks like a datagen-only API, so it should be behind the datagen feature
There was a problem hiding this comment.
let's discuss this API before submission in the ICU4X meeting today.
There was a problem hiding this comment.
On talking to Younies: the way to construct the Parser should be a method from the MeasureUnitConversionFactory which is what owns the data
We should:
- Temporarily mark this
cfg(feature = datagen)(since it's still needed by datagen) - Rename it to
from_payload() - Add a todo to revisit the public nature of the API
- (separate PR) make this constructable from a Factory
|
Consider renaming the PR to "Split MeasureUnit into MeasureUnitParser and MeasureUnit". You're not really implementing anything here. |
younies
changed the title
MeasureUnitParserMeasureUnitParser and MeasureUnit
younies
changed the title
MeasureUnitParser and MeasureUnitMeasureUnit into MeasureUnitParser and MeasureUnit
robertbastian
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.