Make DataPayload::new_owned() no longer const #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
added
the
needs-approval
Manishearth
force-pushed
the
non-const-datapayload
branch
from
0680a15
to
6a11634
Compare
sffc
approved these changes
Dec 13, 2023
zbraniecki
approved these changes
Dec 16, 2023
Given that we have approval from 2 organizations, I think we can consider this mergeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically breaking, but I think this constness was a mistake and we don't use it internally (and there's very little reason for someone to use it externally, the static stuff exists).
This is useful for #4449 ; it allows us to reference statics in the constructor of
DataPayload()which lets us reference a proper sentinel rather than a made-up value that will not work in WASM.Needs approval: