Use packed data within ChineseBasedYearInfo #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
chinese-packed
branch
from
5f5eff6
to
cd80a7d
Compare
sffc
approved these changes
Dec 18, 2023
| /// ``` | ||
| /// | ||
| /// Where the New Year Offset is the offset from ISO Jan 21 of that year for Chinese New Year, | ||
| /// the month lengths are stored as 1 = 30, 0 = 29 for each month including the leap month. | ||
| #[derive(Debug, Copy, Clone)] | ||
| /// | ||
| /// Should not |
There was a problem hiding this comment.
... I have absolutely no idea
There was a problem hiding this comment.
I'll fix this in the upcoming PR; this type will probably move to provider/chinese_based.rs anyway
| !month_lengths[12] || leap_month_idx.is_some(), | ||
| "Last month length should not be set for non-leap years" | ||
| ); | ||
| debug_assert!(ny_offset < 32, "Year offset too big to store"); |
There was a problem hiding this comment.
Thought: You don't have much wiggle room here; I think you are making use of all 32 values :)
There was a problem hiding this comment.
Potentially 31, but yes. Andrew and I spent some time researching this but I do plan to run a test on every year to check this property.
Comment on lines
+192
to
+193
| prev_month_lengths += long_month_bits.count_ones().try_into().unwrap_or(0); | ||
| prev_month_lengths |
There was a problem hiding this comment.
Praise: clever use of count_ones()
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3933
This does not yet add data loading, but it gets very close to it.
This PR makes the size of Date not bloat too much, without requiring much computation for any of the getters -- they're all basic bit operations.