Make ZeroVec have a niche via NonNull #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
force-pushed
the
nonnull-zerovec
branch
from
fb2ecf1
to
08af4f0
Compare
Manishearth
previously approved these changes
Dec 23, 2023
Manishearth
reviewed
Dec 23, 2023
sffc
commented
Dec 23, 2023
Comment on lines
+320
to
+323
| // Safety: `ptr` comes from Vec::as_mut_ptr, which says: | ||
| // "Returns an unsafe mutable pointer to the vector’s buffer, | ||
| // or a dangling raw pointer valid for zero sized reads" | ||
| buf: unsafe { NonNull::new_unchecked(slice) }, |
There was a problem hiding this comment.
Is this safety comment valid? If the vector is empty, is it guaranteed that the dangling pointer is non-null?
There was a problem hiding this comment.
^ @Manishearth you approved the PR but can you confirm my question about the dangling pointer being non-null?
Manishearth
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this good? Gives us a niche so that
Option<ZeroVec>doesn't add a whole word.